Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2928] [core] Update foreign pod resource usage #990

Closed
wants to merge 1 commit into from

Conversation

pbacsko
Copy link
Contributor

@pbacsko pbacsko commented Oct 29, 2024

What is this PR for?

Support resource updates for foreign allocations.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2928

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.46%. Comparing base (1e5d68b) to head (429bd44).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #990      +/-   ##
==========================================
+ Coverage   81.31%   81.46%   +0.14%     
==========================================
  Files          97       97              
  Lines       15483    15511      +28     
==========================================
+ Hits        12590    12636      +46     
+ Misses       2610     2595      -15     
+ Partials      283      280       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pbacsko pbacsko marked this pull request as draft October 29, 2024 14:36
@pbacsko pbacsko changed the title [YUNIKORN-2928] [core] Update foreign pod resource usage DRAFT [YUNIKORN-2928] [core] Update foreign pod resource usage Oct 29, 2024
@pbacsko pbacsko force-pushed the YUNIKORN-2928 branch 4 times, most recently from 300304e to 616fbd2 Compare October 30, 2024 12:27
@pbacsko pbacsko marked this pull request as ready for review October 30, 2024 13:02
@pbacsko pbacsko changed the title DRAFT [YUNIKORN-2928] [core] Update foreign pod resource usage [YUNIKORN-2928] [core] Update foreign pod resource usage Oct 30, 2024
@pbacsko
Copy link
Contributor Author

pbacsko commented Oct 30, 2024

Failed e2e test seems to be unrelated.

@pbacsko pbacsko force-pushed the YUNIKORN-2928 branch 2 times, most recently from 07c61d4 to d7d68f7 Compare October 30, 2024 15:13
Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants